Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update example docs to match tests #807

Merged
merged 3 commits into from
Mar 28, 2024
Merged

fix: update example docs to match tests #807

merged 3 commits into from
Mar 28, 2024

Conversation

rubysolo
Copy link
Contributor

Fixes #804

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@rubysolo rubysolo force-pushed the update-docs branch 2 times, most recently from 5cdf74e to 908c1eb Compare March 14, 2024 21:42
@rubysolo rubysolo changed the title update example docs to match tests chore: update example docs to match tests Mar 14, 2024
MikeMcC399

This comment was marked as resolved.

Sign in to view

@jennifer-shehane jennifer-shehane changed the title chore: update example docs to match tests fix: update example docs to match tests Mar 19, 2024
@rubysolo
fix: update example docs to match tests
19976f4 
also removes meaningless `end` tests and examples
@MikeMcC399

This comment was marked as resolved.

Sign in to view
@MikeMcC399

This comment was marked as outdated.

Sign in to view
MikeMcC399

This comment was marked as resolved.

Sign in to view

@jennifer-shehane
Copy link
Member

@MikeMcC399 I removed this last reference to 'end' command

MikeMcC399
MikeMcC399 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Good work @rubysolo !

@jennifer-shehane jennifer-shehane merged commit 723fb32 into cypress-io:master Mar 28, 2024
10 checks passed
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 2.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 31, 2024
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

@MikeMcC399 MikeMcC399 MikeMcC399 approved these changes

Assignees

@rubysolo rubysolo

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update HTML examples to conform to scaffolded tests
5 participants
@rubysolo @CLAassistant @cypress-app-bot @MikeMcC399 @jennifer-shehane